Docs: updates route-level idle timeout ID #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pomerium-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nhayfield
approved these changes
Jan 29, 2024
backport-actions-token bot
pushed a commit
that referenced
this pull request
Jan 29, 2024
updates route-level idle timeout ID
ZPain8464
added a commit
that referenced
this pull request
Jan 29, 2024
Docs: updates route-level idle timeout ID (#1206) updates route-level idle timeout ID Co-authored-by: zachary painter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know we've documented internally how we document our route- and global-level conventions, but this setting predates those decisions. For now, I've updated the route-level idle timeout setting ID to
route-idle-timeout, as that was the original name given to the route-level setting. The Console and Zero repos' help docs also label this setting "route-idle-timeout."I've filed issues on both repos to update the ID:
Fixes #1205